fix: non-organizer user can't set email null #7378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maze-runnar
changed the title
Codecov Report
@@ Coverage Diff @@
## development #7378 +/- ##
============================================
Coverage 64.24% 64.24%
============================================
Files 259 259
Lines 13133 13136 +3
============================================
+ Hits 8437 8439 +2
- Misses 4696 4697 +1
Continue to review full report at Codecov.
|
app/api/speakers.py
Outdated
| @@ -81,7 +81,13 @@ def before_post(self, args, kwargs, data=None): | |||
| and not data.get('email') | |||
| ): | |||
| data['email'] = current_user.email | |||
|
|
|||
| if ( | |||
| not has_access('is_organizer', event_id=data['event']) | |||
There was a problem hiding this comment.
has_access('is_organizer', event_id=data['event']) is accessed already, so save it in a variable and reuse elsewhere
Co-authored-by: Areeb Jamal <[email protected]>
…y, so save it in a variable and reusing elsewhere
Co-authored-by: Areeb Jamal <[email protected]>
app/api/speakers.py
Outdated
| @@ -75,13 +75,20 @@ def before_post(self, args, kwargs, data=None): | |||
| {'pointer': 'data/attributes/is_email_overridden'}, | |||
| 'Organizer access required to override email', | |||
| ) | |||
| is_organizer = has_access('is_organizer', event_id=data['event']) | |||
There was a problem hiding this comment.
Used above this condition as well
iamareebjamal
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: fossasia/open-event-frontend#5359
Checklist
developmentbranch.