Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restrict event query API #7389

Merged
merged 2 commits into from
Nov 2, 2020
Merged

fix: Restrict event query API #7389

merged 2 commits into from
Nov 2, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 30, 2020

Fixes #7390

  • Fix event query logic
  • Separate restricted queries and unrestricted queries
  • Throw unconditionally for draft events
  • Refactor and simplify login detection code

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #7389 into development will increase coverage by 0.07%.
The diff coverage is 88.88%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7389      +/-   ##
===============================================
+ Coverage        64.59%   64.67%   +0.07%     
===============================================
  Files              262      262              
  Lines            13246    13247       +1     
===============================================
+ Hits              8556     8567      +11     
+ Misses            4690     4680      -10     
Impacted Files Coverage Δ
app/api/helpers/query.py 88.00% <88.88%> (+33.45%) ⬆️
app/api/users.py 29.14% <0.00%> (-2.15%) ⬇️
app/api/custom/invoices.py 34.78% <0.00%> (-1.39%) ⬇️
app/models/user.py 65.15% <0.00%> (-0.49%) ⬇️
app/api/orders.py 40.97% <0.00%> (-0.32%) ⬇️
config.py 88.75% <0.00%> (-0.14%) ⬇️
app/api/custom/orders.py 37.71% <0.00%> (ø)
app/api/helpers/permission_manager.py 62.83% <0.00%> (+1.01%) ⬆️
app/models/order.py 91.42% <0.00%> (+1.01%) ⬆️
app/api/attendees.py 56.19% <0.00%> (+4.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47eb8e2...435da10. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix: Restrict event attendee API fix: Restrict event query API Nov 2, 2020
@iamareebjamal iamareebjamal merged commit 5459387 into development Nov 2, 2020
@iamareebjamal iamareebjamal deleted the attendee-access branch November 2, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anonymous user can access event attendees
1 participant