Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add direct ICS export URL #7414

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Nov 4, 2020

@auto-label auto-label bot added the feature label Nov 4, 2020
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #7414 into development will increase coverage by 0.04%.
The diff coverage is 82.81%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7414      +/-   ##
===============================================
+ Coverage        64.70%   64.75%   +0.04%     
===============================================
  Files              263      265       +2     
  Lines            13284    13313      +29     
===============================================
+ Hits              8596     8621      +25     
- Misses            4688     4692       +4     
Impacted Files Coverage Δ
app/api/helpers/permissions.py 36.20% <0.00%> (+0.30%) ⬆️
app/api/helpers/tasks.py 16.75% <ø> (ø)
app/api/custom/calendars.py 50.00% <50.00%> (ø)
app/api/helpers/calendar/ical.py 97.29% <97.29%> (ø)
app/api/helpers/ICalExporter.py 100.00% <100.00%> (+2.85%) ⬆️
app/instance.py 88.04% <100.00%> (+0.13%) ⬆️
app/models/event.py 78.63% <100.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c0115...6e4fb73. Read the comment docs.

@iamareebjamal iamareebjamal merged commit b51eda5 into fossasia:development Nov 4, 2020
@iamareebjamal iamareebjamal deleted the ical-direct branch November 4, 2020 09:11
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 4, 2020

This pull request fixes 1 alert when merging 6e4fb73 into 41c0115 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant