Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Add comma in storage options docs #7415

Merged
merged 4 commits into from
Nov 6, 2020
Merged

chore(docs): Add comma in storage options docs #7415

merged 4 commits into from
Nov 6, 2020

Conversation

Lakshita2002
Copy link
Contributor

Currently fixes no issue

Short description of what this resolves:

Improves the grammar of README.md

Changes proposed in this pull request:

  • made changes to 2 sentences to improve the grammatical tone of it
  • a sentence generally does not have 2 or's followed by an either
  • "by using [tech]" is a better term than "using [tech]"

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #7415 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7415   +/-   ##
============================================
  Coverage        64.74%   64.74%           
============================================
  Files              265      265           
  Lines            13319    13319           
============================================
  Hits              8624     8624           
  Misses            4695     4695           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e4d76...b70775e. Read the comment docs.

snitin315
snitin315 previously approved these changes Nov 5, 2020
@iamareebjamal iamareebjamal changed the title slightly improved README.md grammar chore(docs): Add comma in storage options docs Nov 6, 2020
@auto-label auto-label bot added the docs label Nov 6, 2020
@iamareebjamal iamareebjamal merged commit f0cf6a2 into fossasia:development Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants