Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ref): Refactor order complete logic #7418

Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Nov 6, 2020

Fixes #7412

Organizer will now receive emails about ticket purchase

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #7418 into development will increase coverage by 0.53%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7418      +/-   ##
===============================================
+ Coverage        64.74%   65.28%   +0.53%     
===============================================
  Files              265      265              
  Lines            13319    13205     -114     
===============================================
- Hits              8624     8621       -3     
+ Misses            4695     4584     -111     
Impacted Files Coverage Δ
app/api/custom/attendees.py 48.00% <0.00%> (ø)
app/api/custom/invoices.py 36.95% <0.00%> (+0.78%) ⬆️
app/api/helpers/system_mails.py 100.00% <ø> (ø)
app/api/helpers/mail.py 40.76% <30.00%> (-0.51%) ⬇️
app/api/helpers/ticketing.py 52.73% <33.33%> (+3.34%) ⬆️
app/api/helpers/order.py 63.04% <35.71%> (-3.90%) ⬇️
app/api/custom/orders.py 70.73% <50.00%> (+33.01%) ⬆️
app/api/orders.py 43.39% <66.66%> (+2.02%) ⬆️
app/api/helpers/notification.py 78.31% <75.00%> (ø)
app/models/order.py 88.50% <75.00%> (-1.91%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e4d76...1369d9d. Read the comment docs.

@iamareebjamal iamareebjamal merged commit a01692a into fossasia:development Nov 6, 2020
@iamareebjamal iamareebjamal deleted the order-complete-ref branch November 6, 2020 09:11
@mariobehling
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix order complete and email sending logic
2 participants