Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show Location, Online Event, Mixed Event or To be Announced info correctly #7447

Merged

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes fossasia/open-event-frontend#5614

Short description of what this resolves:

This PR update the area to show the information according to the attendee pdf as follows:

  • When an event has a location, show "At" and the location behind.
  • When an event is an online event show "Online Event"
  • When the event is a mixed event show "Event taking place online and at [location here]."
  • When an event location or online details are "to be announced" show: "Location or online event details to be announced".

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

screenshots

s5

s6

s7

s8

@auto-label auto-label bot added the fix label Nov 15, 2020
@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #7447 (15477ad) into development (af5d617) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7447   +/-   ##
============================================
  Coverage        65.35%   65.35%           
============================================
  Files              265      265           
  Lines            13225    13225           
============================================
  Hits              8643     8643           
  Misses            4582     4582           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af5d617...15477ad. Read the comment docs.

@iamareebjamal
Copy link
Member

iamareebjamal commented Nov 15, 2020

What about ticket_purchaser.html?

@sachinchauhan2889
Copy link
Contributor Author

What about ticket_purchaser.html?

@iamareebjamal sir, done.

@iamareebjamal iamareebjamal merged commit e0ca6e8 into fossasia:development Nov 15, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the attendee-pdf-fix branch November 15, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Page and Ticket PDF Download: Show Location, Online Event, Mixed Event or To be Announced info correctly
2 participants