Restore cast script #2937
Merged
Restore cast script #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: Please remember that this PR fixes cast scripts, so tests and linting outside of sncast crate are still failing. |
franciszekjob
requested review from
cptartur,
ddoktorski and
kkawula
as code owners
ddoktorski
reviewed
Feb 14, 2025
franciszekjob
requested review from
ddoktorski
and removed request for
a team
…ub.com/foundry-rs/starknet-foundry into franciszekjob/2933-restore-cast-script
…ub.com/foundry-rs/starknet-foundry into franciszekjob/2933-restore-cast-script
Once I changed usage of |
|
|
cptartur
approved these changes
Feb 18, 2025
Comment on lines
+337
to
+366
| let param_types = builder.generic_id_and_size_from_concrete(&func.signature.param_types); | ||
| let base_offset = 5; | ||
| // * Segment arena is allocated conditionally, so segment index is automatically moved (+2 segments) | ||
| // * Each used builtin moves the offset by +1 | ||
| // * Line `let mut builtin_offset = 3;` in `create_entry_code_from_params` | ||
| // * TODO Where is remaining +2 in base offset coming from? Maybe System builtin and Gas builtin which seem to be always included | ||
| let segment_index = if param_types | ||
| .iter() | ||
| .any(|(ty, _)| ty == &SegmentArenaType::ID) | ||
| { | ||
| // FIXME verify this | ||
| base_offset + builtins.len() + 2 | ||
| } else { | ||
| // FIXME verify this | ||
| base_offset + builtins.len() | ||
| }; | ||
| let syscall_handler = SyscallHintProcessor::new( | ||
| &mut blockifier_state, | ||
| &mut context, | ||
| // This segment is created by SierraCasmRunner | ||
| Relocatable { | ||
| segment_index: segment_index | ||
| .try_into() | ||
| .expect("Failed to convert index to isize"), | ||
| offset: 0, | ||
| }, | ||
| CallEntryPoint::default(), | ||
| &string_to_hint, | ||
| ReadOnlySegments::default(), | ||
| ); |
There was a problem hiding this comment.
Add a TODO here to extract the copied code to common function.
franciszekjob
merged commit 07cda7e
into
kkawula/2862-bump-cairo-and-blockifier
15 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2933
Introduced changes
Restore cast script by adjusting
runfunctionChecklist
CHANGELOG.md