Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust trace resources tests #2985

Draft
wants to merge 139 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
139 commits
Select commit Hold shift + click to select a range
8840619
Update `Cargo.toml`
kkawula Jan 21, 2025
28c45de
Fix 0
kkawula Jan 21, 2025
3a300f1
Fix imports
kkawula Jan 21, 2025
4f00198
Undo unnecessary lock update
kkawula Jan 21, 2025
66f4b8e
Use `blockifier` and `starknet_api` from crates.io
kkawula Jan 23, 2025
afdc132
Fix 4
kkawula Jan 23, 2025
e37424a
Rename `get_compiled_contract_class` to `get_compiled_class`
kkawula Jan 27, 2025
9cdc581
Fix imports
kkawula Jan 27, 2025
69117b5
Update `verify_syscall_ptr` return type
kkawula Jan 27, 2025
a8a58a8
Specify int size for From triat
kkawula Jan 27, 2025
320be6b
Moc `From` impl for GasPrices and SerializableGasPrices
kkawula Jan 27, 2025
ec98539
Fix imports
kkawula Jan 27, 2025
a60a110
Update `get_compiled_class` return type
kkawula Jan 27, 2025
57af9ee
Revert changes in 'StarknetRuntime' struct
kkawula Jan 27, 2025
16eab87
Add `Mock` comment
kkawula Jan 27, 2025
3d469df
Revert `verify_syscall_ptr` type change
kkawula Jan 27, 2025
23e7b5d
Add `Mock` comment
kkawula Jan 27, 2025
ab1a722
Some fixes
kkawula Jan 30, 2025
c239c2c
Add mock comment
kkawula Jan 30, 2025
9bd480f
Some fixes
kkawula Jan 30, 2025
51bb4b6
Some fixes - update imports
kkawula Jan 30, 2025
dda8c59
Fix error match
kkawula Jan 30, 2025
c32f3bf
Fix
kkawula Jan 30, 2025
96e7854
Compiles
cptartur Jan 31, 2025
7ad3ed5
Make
cptartur Feb 4, 2025
f7d8b8f
Fix panic data extraction logic for string, disable for shortstrings …
cptartur Feb 5, 2025
00f48b2
Disable asserted gas values in non-gas tests
cptartur Feb 5, 2025
7371458
Move builtins test to separate file
cptartur Feb 5, 2025
eb4249f
Disable fuzzing tests
cptartur Feb 5, 2025
ac9d4f8
Try handling segment index offsets
cptartur Feb 5, 2025
d6e09bc
Add todo
cptartur Feb 5, 2025
34260c7
Remove todos from constants.rs
cptartur Feb 5, 2025
c6905bc
Add better comments on gas
cptartur Feb 5, 2025
fbff61a
Remove TODO in entry_code.rs
cptartur Feb 5, 2025
d758939
Add fixme
cptartur Feb 6, 2025
42f6b4b
gas.rs wip
cptartur Feb 6, 2025
e223c8d
Restore some resources related code
cptartur Feb 6, 2025
4592ca6
Some gas changes
cptartur Feb 6, 2025
9fe02fe
Add up gas from nested calls (some calculations are now correct)
cptartur Feb 7, 2025
94f655a
Update gas tests following price changes
cptartur Feb 7, 2025
6db75f2
Add fixme to l1 gas tests
cptartur Feb 7, 2025
2c8710a
Return total of l1 gas (maintain old behavior
cptartur Feb 7, 2025
a091e9c
Set class hash for mocked calls
cptartur Feb 7, 2025
f9c5de0
Restore passing used resources
cptartur Feb 7, 2025
e0db970
Partially fix regex
cptartur Feb 10, 2025
530b484
Disable fuzzing gas test
cptartur Feb 11, 2025
9469994
Mock gas tests
cptartur Feb 11, 2025
b6fcfac
Fix traces (modify blockifer code)
cptartur Feb 11, 2025
18505a0
Merge branch 'master' into kkawula/2862-bump-cairo-and-blockifier
kkawula Feb 13, 2025
e19a51a
Fmt + typos
kkawula Feb 13, 2025
99666f3
Fix imports
kkawula Feb 13, 2025
d915211
Remove MOCK remaining_gas
kkawula Feb 13, 2025
036dd17
Implement From traint for `SerializableBlockInfo` and `GasPrices`
kkawula Feb 13, 2025
0591167
Refactor returned gas vector in `calculate_used_gas`
franciszekjob Feb 14, 2025
29a8b32
Use actual `signature_length` from tx info
franciszekjob Feb 14, 2025
da5d539
Add mocked `calculate_calldata_length`
franciszekjob Feb 14, 2025
fdfcea1
Update todo
franciszekjob Feb 14, 2025
3d05ceb
Pass `calldata` and `code_size`
franciszekjob Feb 15, 2025
0acf56f
Use real abi length
franciszekjob Feb 15, 2025
a063346
Add sierra gas calculation
franciszekjob Feb 16, 2025
8d3c88a
Remove todo
franciszekjob Feb 16, 2025
61d824f
Temporarily use 0 as abi length
franciszekjob Feb 16, 2025
9d7d522
Linting
franciszekjob Feb 16, 2025
4b69b52
Update returned values in `calculate_libfunc_cost`
franciszekjob Feb 16, 2025
46f5bcc
Refactor `calculate_sierra_gas`
franciszekjob Feb 17, 2025
fde27a3
Refactor `calculate_libfunc_cost`
franciszekjob Feb 17, 2025
ab0f9b4
Add comments with detailed execution resources for each gas test
franciszekjob Feb 17, 2025
612d991
Remove `calculate_sierra_gas` and `calculate_libfunc_cost`
franciszekjob Feb 17, 2025
b61a4b1
fix resources in traces
THenry14 Feb 17, 2025
f755995
Remove cairo-annotations branch dependency (#2948)
ksew1 Feb 17, 2025
9f14822
Remove `state_resources` param from `get_archival_data_resources`
franciszekjob Feb 17, 2025
56e5d45
Formatting
franciszekjob Feb 17, 2025
ad34248
Fix failing tests
franciszekjob Feb 17, 2025
f477cd3
Fix total resources
cptartur Feb 17, 2025
f5dbce2
Remove code size, calldata length and signature length calculations
franciszekjob Feb 17, 2025
91ef39c
Merge branch 'kkawula/2935-go-over-the-code-and-verify-mocks-todo-fix…
cptartur Feb 17, 2025
591399c
Add comments with calculations explanations in integration gas tests
franciszekjob Feb 17, 2025
e8694f9
Remove "FIXME"; Minor comments fixes
franciszekjob Feb 17, 2025
95684ed
Remove comment
franciszekjob Feb 17, 2025
c3534fd
Restore comments
franciszekjob Feb 17, 2025
3959be8
Fix most lints
cptartur Feb 17, 2025
2191e39
Link to copied code
cptartur Feb 17, 2025
c1bc13f
Add `ENTRYPOINT_FAILED_ERROR` to `execute_inner_call` error (similar …
cptartur Feb 17, 2025
89916b1
Move default class hash for mocked call info logic to `mocked_call_info`
cptartur Feb 17, 2025
15269b3
Remove commented out `resources` in `exit_nested_call`
cptartur Feb 17, 2025
07cda7e
Restore cast script (#2937)
franciszekjob Feb 18, 2025
726c120
Remove commented out code related to traces
cptartur Feb 18, 2025
e32fac1
Merge remote-tracking branch 'origin/kkawula/2862-bump-cairo-and-bloc…
cptartur Feb 18, 2025
3ae1d62
Allow lint in copied code
cptartur Feb 18, 2025
087a318
Add comment in `l1_handler_cost` test
franciszekjob Feb 18, 2025
287160c
Update asserted gas value in `multiple_storage_writes_cost` test
franciszekjob Feb 18, 2025
7cc9774
Update comment
franciszekjob Feb 18, 2025
1811b11
Merge branch 'kkawula/2862-bump-cairo-and-blockifier' of https://gith…
franciszekjob Feb 18, 2025
fd1d4c9
Remove more commented out code
cptartur Feb 18, 2025
03b05fb
Update comment
franciszekjob Feb 18, 2025
dd85a14
Use `i64` as max gas for now
cptartur Feb 19, 2025
638dcfd
Remove debug prints
cptartur Feb 19, 2025
2b39e5c
Merge branch 'master' into kkawula/2862-bump-cairo-and-blockifier
cptartur Feb 19, 2025
fc05901
Remove old fuzzing related code
cptartur Feb 19, 2025
6e5ebc9
Restore fuzzing tests
cptartur Feb 19, 2025
6f99292
Bump deps
cptartur Feb 19, 2025
aa32a9c
Fix typo
cptartur Feb 19, 2025
2e2608f
Closes #2954
cptartur Feb 19, 2025
2dba836
Bump minimal scarb version
cptartur Feb 19, 2025
56f6cab
Merge branch 'kkawula/2862-bump-cairo-and-blockifier' of https://gith…
franciszekjob Feb 19, 2025
92985cc
Fix `multiple_storage_writes_cost` test
franciszekjob Feb 19, 2025
eeb9bfd
Link to issue regarding blockifier copied code
cptartur Feb 20, 2025
ea12624
Link to issue regarding cairo copied code
cptartur Feb 20, 2025
20c10b3
Restore remaining fuzzing test
cptartur Feb 20, 2025
a9d53e1
Remove todos
cptartur Feb 20, 2025
e63634e
Move some constants to `runtime` crate
cptartur Feb 20, 2025
c70afa1
Use better default gas value
cptartur Feb 20, 2025
61ed2f8
Remove not relevant todo
cptartur Feb 20, 2025
938a18e
Change visibility of copied function
cptartur Feb 20, 2025
33d8715
Add todo
franciszekjob Feb 20, 2025
9957732
Merge branch 'kkawula/2862-bump-cairo-and-blockifier' into franciszek…
franciszekjob Feb 20, 2025
e9a0c84
Update cairo annotations, add missing mapping
cptartur Feb 20, 2025
c0d61cb
Apply ode review suggestions
franciszekjob Feb 20, 2025
3d160d9
Use blockifier from fork
cptartur Feb 20, 2025
758d01b
Merge branch 'kkawula/2862-bump-cairo-and-blockifier' into franciszek…
cptartur Feb 20, 2025
57b28ca
Link issue in code
cptartur Feb 20, 2025
8cb4339
Link issue in code
cptartur Feb 20, 2025
7d6d00d
Disable default features
cptartur Feb 21, 2025
2d6975b
Merge branch 'kkawula/2862-blockifier-windows-compatible-fork' into k…
cptartur Feb 21, 2025
67ad52a
Relock
cptartur Feb 21, 2025
8472cf3
Lint
cptartur Feb 21, 2025
a5cf9be
Bump starknet, assert_macros, remove unused code
cptartur Feb 21, 2025
25e8a25
Remove `scarb 2.7.0` override in cast tests
cptartur Feb 21, 2025
e55274a
Merge branch 'kkawula/2862-bump-cairo-and-blockifier' into 2964-docs-…
cptartur Feb 21, 2025
2e39f55
Remove unused argument
cptartur Feb 21, 2025
db377e3
Do not hardcode `use_kzg_da`
cptartur Feb 21, 2025
1c39a6f
Link to sierra gas issue
cptartur Feb 21, 2025
9b69e26
Change fixme to todo
cptartur Feb 21, 2025
6ff179f
Copy updated code, link to source
cptartur Feb 21, 2025
4d87d44
Merge branch '2964-docs-tests' into kkawula/2862-bump-cairo-and-block…
cptartur Feb 21, 2025
f1a8461
Remove commented out code
cptartur Feb 21, 2025
452cc35
Merge branch 'master' of https://github.com/foundry-rs/starknet-found…
franciszekjob Feb 21, 2025
03f554a
Merge branch 'kkawula/2862-bump-cairo-and-blockifier' of https://gith…
franciszekjob Feb 21, 2025
b8a0e0e
Adjust trace resources tests
ddoktorski Feb 22, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,6 @@ jobs:
$DEVNET_INSTALL_DIR = "${{ github.workspace }}\crates\sncast\tests\utils\devnet"
cargo install --git https://github.com/0xSpaceShard/starknet-devnet-rs.git --locked --rev ${{ env.DEVNET_REV }} --root $DEVNET_INSTALL_DIR
- uses: software-mansion/setup-scarb@v1
with:
scarb-version: "2.7.0"
- uses: software-mansion/setup-universal-sierra-compiler@v1
- name: Run tests
run: cargo test --release -p sncast
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
scarb 2.7.0
scarb 2.8.5
Loading
Loading