Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of target-info #405

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Oct 2, 2023

This PR aims to improve the stability of target-info when used on targets without optional _os.py functions.

@pyrco pyrco linked an issue Oct 4, 2023 that may be closed by this pull request
Copy link
Contributor

@pyrco pyrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the other MRs linked to #256 are fixed, the only thing left is to make the architecture function an official OSPlugin function. We have an internal ticket for this. So this MR is good to go.

@pyrco pyrco force-pushed the improvement/target-info branch from b3e4af0 to d9da2f2 Compare October 9, 2023 09:42
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #405 (d9da2f2) into main (266b8f2) will increase coverage by 0.02%.
The diff coverage is 5.88%.

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   73.77%   73.79%   +0.02%     
==========================================
  Files         252      252              
  Lines       20194    20189       -5     
==========================================
+ Hits        14898    14899       +1     
+ Misses       5296     5290       -6     
Flag Coverage Δ
unittests 73.79% <5.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dissect/target/tools/info.py 27.84% <5.88%> (+2.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pyrco pyrco merged commit 8eed209 into fox-it:main Oct 9, 2023
Schamper pushed a commit that referenced this pull request Oct 27, 2023
@JSCU-CNI JSCU-CNI deleted the improvement/target-info branch January 4, 2024 13:03
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin errors for domain and datetime
2 participants