Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the wireguard plugin more robust against missing data #407

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Oct 4, 2023

(DIS-2353)

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #407 (6beeb27) into main (c35096b) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 6beeb27 differs from pull request most recent head 847816f. Consider uploading reports for the commit 847816f to get more accurate results

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   73.76%   73.69%   -0.07%     
==========================================
  Files         252      251       -1     
  Lines       20188    20180       -8     
==========================================
- Hits        14892    14872      -20     
- Misses       5296     5308      +12     
Flag Coverage Δ
unittests 73.69% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dissect/target/plugins/apps/vpns/wireguard.py 87.93% <100.00%> (+1.39%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pyrco pyrco force-pushed the feature/dis-2353_make-wireguard-plugin-more-robust branch from dfae0f0 to 6beeb27 Compare October 5, 2023 11:30
@pyrco pyrco requested a review from Miauwkeru October 5, 2023 11:31
@pyrco pyrco requested a review from Miauwkeru October 6, 2023 15:19
@pyrco pyrco force-pushed the feature/dis-2353_make-wireguard-plugin-more-robust branch from 6beeb27 to 847816f Compare October 9, 2023 08:23
@pyrco pyrco merged commit 266b8f2 into main Oct 9, 2023
@pyrco pyrco deleted the feature/dis-2353_make-wireguard-plugin-more-robust branch October 9, 2023 08:35
Schamper pushed a commit that referenced this pull request Oct 27, 2023
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants