Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin lookups for the DefaultPlugin #408

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Oct 5, 2023

(DIS-2357)

@pyrco pyrco linked an issue Oct 5, 2023 that may be closed by this pull request
@pyrco pyrco force-pushed the feature/dis-2357_fix-plugin-lookups-for-default-plugin branch from f435a3d to d27fc28 Compare October 6, 2023 14:20
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #408 (9650b9d) into main (8eed209) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   73.79%   73.79%           
=======================================
  Files         252      252           
  Lines       20189    20189           
=======================================
  Hits        14899    14899           
  Misses       5290     5290           
Flag Coverage Δ
unittests 73.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dissect/target/plugin.py 90.41% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pyrco pyrco requested a review from Schamper October 9, 2023 06:11
Schamper
Schamper previously approved these changes Oct 9, 2023
@pyrco pyrco force-pushed the feature/dis-2357_fix-plugin-lookups-for-default-plugin branch from d27fc28 to 4e32e6d Compare October 9, 2023 09:54
@pyrco pyrco force-pushed the feature/dis-2357_fix-plugin-lookups-for-default-plugin branch from 4e32e6d to 9650b9d Compare October 9, 2023 10:06
@pyrco pyrco requested a review from Schamper October 9, 2023 10:40
@pyrco pyrco merged commit d3c195e into main Oct 9, 2023
@pyrco pyrco deleted the feature/dis-2357_fix-plugin-lookups-for-default-plugin branch October 9, 2023 11:09
Schamper pushed a commit that referenced this pull request Oct 27, 2023
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin errors for domain and datetime
2 participants