Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checks on non-existing or non-compatible plugins #410

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Oct 9, 2023

(DIS-2387)

@pyrco pyrco requested a review from Miauwkeru October 9, 2023 09:38
@pyrco pyrco linked an issue Oct 9, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #410 (9d5ab4f) into main (795cd7e) will decrease coverage by 0.04%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   73.95%   73.91%   -0.04%     
==========================================
  Files         255      255              
  Lines       20289    20240      -49     
==========================================
- Hits        15005    14961      -44     
+ Misses       5284     5279       -5     
Flag Coverage Δ
unittests 73.91% <83.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dissect/target/helpers/network_managers.py 83.82% <100.00%> (ø)
dissect/target/plugins/child/wsl.py 96.29% <100.00%> (ø)
dissect/target/plugins/apps/webservers/iis.py 85.93% <50.00%> (ø)

... and 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pyrco pyrco force-pushed the feature/dis-2387_better-plugin-failure-check branch from f2c2496 to 9d5ab4f Compare October 10, 2023 06:29
@pyrco pyrco merged commit 810ae14 into main Oct 10, 2023
@pyrco pyrco deleted the feature/dis-2387_better-plugin-failure-check branch October 10, 2023 07:41
Schamper pushed a commit that referenced this pull request Oct 27, 2023
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin errors for domain and datetime
2 participants