Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the architecture function to OSPlugin #414

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Oct 12, 2023

This function is now mandatory to be implemented by all OSPlugin subclasses.

(DIS-2386)

@pyrco pyrco requested a review from Miauwkeru October 12, 2023 11:48
@pyrco pyrco linked an issue Oct 12, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #414 (06a6fce) into main (b5faf93) will increase coverage by 0.11%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   73.87%   73.99%   +0.11%     
==========================================
  Files         255      255              
  Lines       20240    20304      +64     
==========================================
+ Hits        14953    15024      +71     
+ Misses       5287     5280       -7     
Flag Coverage Δ
unittests 73.99% <83.33%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dissect/target/plugin.py 91.26% <100.00%> (+1.00%) ⬆️
dissect/target/plugins/os/unix/_os.py 77.29% <100.00%> (+0.54%) ⬆️
dissect/target/plugins/os/unix/bsd/osx/_os.py 89.85% <66.66%> (-1.06%) ⬇️
dissect/target/plugins/general/default.py 90.47% <82.35%> (-0.44%) ⬇️

... and 35 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pyrco pyrco force-pushed the feature/dis-2386_add-architecture-function-to-osplugin branch from cbc65ae to ce0937b Compare October 12, 2023 14:08
@pyrco pyrco requested a review from Schamper October 12, 2023 14:08
@pyrco pyrco force-pushed the feature/dis-2386_add-architecture-function-to-osplugin branch from ce0937b to 2d9f74e Compare October 12, 2023 14:29
This function is now mandatory to be implemented by all OSPlugin
subclasses.

(DIS-2386)
@pyrco pyrco force-pushed the feature/dis-2386_add-architecture-function-to-osplugin branch from 2d9f74e to 06a6fce Compare October 13, 2023 07:16
@pyrco pyrco requested a review from Schamper October 13, 2023 07:17
@pyrco pyrco merged commit a008650 into main Oct 13, 2023
@pyrco pyrco deleted the feature/dis-2386_add-architecture-function-to-osplugin branch October 13, 2023 08:11
Schamper pushed a commit that referenced this pull request Oct 27, 2023
This function is now mandatory to be implemented by all OSPlugin
subclasses.

(DIS-2386)
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
This function is now mandatory to be implemented by all OSPlugin
subclasses.

(DIS-2386)
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
This function is now mandatory to be implemented by all OSPlugin
subclasses.

(DIS-2386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin errors for domain and datetime
2 participants