Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JFFS2 support to Dissect #417

Merged
merged 12 commits into from
Dec 18, 2023

Conversation

JSCU-CNI
Copy link
Contributor

This PR adds support for the Journalling Flash File System version 2 to Dissect.

Depends on fox-it/dissect.jffs#1

@Schamper Schamper self-requested a review October 16, 2023 18:55
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (b534f3a) 74.00% compared to head (d4026ba) 73.94%.

Files Patch % Lines
dissect/target/filesystems/jffs.py 2.73% 71 Missing ⚠️
dissect/target/containers/vhd.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   74.00%   73.94%   -0.06%     
==========================================
  Files         259      260       +1     
  Lines       20955    21032      +77     
==========================================
+ Hits        15508    15553      +45     
- Misses       5447     5479      +32     
Flag Coverage Δ
unittests 73.94% <7.59%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Schamper
Schamper previously approved these changes Nov 7, 2023
@Schamper Schamper merged commit 688dcb9 into fox-it:main Dec 18, 2023
JSCU-CNI added a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
@JSCU-CNI JSCU-CNI deleted the feature/add-jffs-filesystem branch February 15, 2024 12:38
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants