Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tab URL's and MIME type to download record #429

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

Zawadidone
Copy link
Contributor

In some cases the download URL isn't a valid link but a GUID blob:null/<GUID>, while the other tab URL related fields contain useful information about the origin of the downloaded file.

@Zawadidone
Copy link
Contributor Author

Is it better to add the fields to the ChromiumMixin class?

@pyrco
Copy link
Contributor

pyrco commented Oct 31, 2023

If these fields are only applicable to all chromium based browsers (Edge also does it this way?), then I'd add them there. If something like mime_type also becomes available for Firefox, we can always migrate that property to the generic record fields.

@Zawadidone
Copy link
Contributor Author

Okay I will add the fields to the record (https://github.com/Zawadidone/dissect.target/blob/feature/chromium_tab_urls/dissect/target/plugins/browsers/chromium.py#L31), yes Edge also uses these fields.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #429 (4ae8308) into main (f24e6a2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   74.12%   74.14%   +0.01%     
==========================================
  Files         258      258              
  Lines       20631    20632       +1     
==========================================
+ Hits        15293    15297       +4     
+ Misses       5338     5335       -3     
Flag Coverage Δ
unittests 74.14% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dissect/target/plugins/browsers/chrome.py 100.00% <100.00%> (ø)
dissect/target/plugins/browsers/chromium.py 90.64% <100.00%> (+0.06%) ⬆️
dissect/target/plugins/browsers/edge.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@pyrco pyrco force-pushed the feature/chromium_tab_urls branch from 45a8f44 to 4ae8308 Compare November 10, 2023 13:02
@pyrco pyrco merged commit 3327906 into fox-it:main Nov 10, 2023
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
@Zawadidone Zawadidone deleted the feature/chromium_tab_urls branch February 21, 2024 18:09
Zawadidone added a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants