-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tab URL's and MIME type to download record #429
Conversation
Is it better to add the fields to the |
If these fields are only applicable to all chromium based browsers (Edge also does it this way?), then I'd add them there. If something like |
Okay I will add the fields to the record (https://github.com/Zawadidone/dissect.target/blob/feature/chromium_tab_urls/dissect/target/plugins/browsers/chromium.py#L31), yes Edge also uses these fields. |
Codecov Report
@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 74.12% 74.14% +0.01%
==========================================
Files 258 258
Lines 20631 20632 +1
==========================================
+ Hits 15293 15297 +4
+ Misses 5338 5335 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
45a8f44
to
4ae8308
Compare
In some cases the download URL isn't a valid link but a GUID
blob:null/<GUID>
, while the other tab URL related fields contain useful information about the origin of the downloaded file.