Change the RunKeyRecord path field to string #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
- Coverage 74.04% 74.04% -0.01%
==========================================
Files 257 257
Lines 20551 20550 -1
==========================================
- Hits 15217 15216 -1
Misses 5334 5334
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Poeloe
requested changes
Oct 31, 2023
pyrco
force-pushed
the
feature/dis-2563_change_runkeys_path_to_string
branch
from
33d848c to
f976443
Compare
The "path" value of a run key is actually a full command. If this command does not have just a path but also things like command parameters, this can not be parsed as a path type. The field is now treated as a normal string to prevent parse errors and in anticipation of a proper command field type. (DIS-2563)
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
The "path" value of a run key is actually a full command. If this command does not have just a path but also things like command parameters, this can not be parsed as a path type. The field is now treated as a normal string to prevent parse errors and in anticipation of a proper command field type. (DIS-2563)
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
The "path" value of a run key is actually a full command. If this command does not have just a path but also things like command parameters, this can not be parsed as a path type. The field is now treated as a normal string to prevent parse errors and in anticipation of a proper command field type. (DIS-2563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "path" value of a run key is actually a full command. If this command does not have just a path but also things like command parameters, this can not be parsed as a path type.
The field is now treated as a normal string to prevent parse errors and in anticipation of a proper command field type.
(DIS-2563)