-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing issue in sshd plugin #433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. I now see that there was a bug with not everything using _value
.
I have no issue with the changes, except the ordering of the test files. (it causes the conflicts)
b61d88a
to
87ee21d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll merge it once it gets through the pipeline
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 74.16% 74.31% +0.15%
==========================================
Files 258 258
Lines 20632 20633 +1
==========================================
+ Hits 15302 15334 +32
+ Misses 5330 5299 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR improves the handling of multiple definitions in the OpenSSHd config plugin.