Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing issue in sshd plugin #433

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Nov 2, 2023

This PR improves the handling of multiple definitions in the OpenSSHd config plugin.

@Schamper Schamper requested a review from Miauwkeru November 7, 2023 23:18
Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. I now see that there was a bug with not everything using _value.

I have no issue with the changes, except the ordering of the test files. (it causes the conflicts)

@JSCU-CNI JSCU-CNI force-pushed the fix/unix-sshd-typing branch from b61d88a to 87ee21d Compare November 14, 2023 10:53
Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge it once it gets through the pipeline

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4aaddc) 74.16% compared to head (87ee21d) 74.31%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   74.16%   74.31%   +0.15%     
==========================================
  Files         258      258              
  Lines       20632    20633       +1     
==========================================
+ Hits        15302    15334      +32     
+ Misses       5330     5299      -31     
Flag Coverage Δ
unittests 74.31% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miauwkeru Miauwkeru merged commit e2e3184 into fox-it:main Nov 14, 2023
JSCU-CNI added a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
@JSCU-CNI JSCU-CNI deleted the fix/unix-sshd-typing branch January 4, 2024 13:04
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants