Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset file position during container, volume and filesystem opening #437

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Nov 7, 2023

Fixes a bug that could happen due to #403

@Schamper Schamper self-assigned this Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #437 (ddcf2f7) into main (61509f5) will increase coverage by 0.01%.
The diff coverage is 82.14%.

@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   74.12%   74.14%   +0.01%     
==========================================
  Files         258      258              
  Lines       20622    20631       +9     
==========================================
+ Hits        15286    15296      +10     
+ Misses       5336     5335       -1     
Flag Coverage Δ
unittests 74.14% <82.14%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dissect/target/containers/ewf.py 65.51% <100.00%> (-2.23%) ⬇️
dissect/target/containers/hdd.py 65.38% <100.00%> (ø)
dissect/target/containers/hds.py 66.66% <100.00%> (-2.30%) ⬇️
dissect/target/containers/qcow2.py 65.38% <100.00%> (-2.48%) ⬇️
dissect/target/containers/raw.py 100.00% <100.00%> (ø)
dissect/target/containers/split.py 83.05% <100.00%> (ø)
dissect/target/containers/vdi.py 65.38% <100.00%> (-2.48%) ⬇️
dissect/target/containers/vhd.py 88.88% <100.00%> (-1.12%) ⬇️
dissect/target/containers/vhdx.py 73.91% <100.00%> (-2.09%) ⬇️
dissect/target/containers/vmdk.py 73.91% <100.00%> (-2.09%) ⬇️
... and 4 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

pyrco
pyrco previously approved these changes Nov 7, 2023
@Schamper Schamper changed the title Reset file position before creating a filesystem Reset file position during container, volume and filesystem opening Nov 7, 2023
@Schamper Schamper merged commit f8d8cf5 into main Nov 7, 2023
@Schamper Schamper deleted the filesystem-seek-0 branch November 7, 2023 23:00
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants