Fix support for unicode paths in target-shell (copy) #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `lexer.whitespace_split = True` to `shlex` which improves handling of unicode arguments for argparse. https://docs.python.org/3/library/shlex.html#shlex.shlex.whitespace_split
Co-authored-by: pyrco <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #440 +/- ##
==========================================
+ Coverage 74.16% 74.31% +0.15%
==========================================
Files 258 258
Lines 20632 20633 +1
==========================================
+ Hits 15302 15334 +32
+ Misses 5330 5299 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
I could not update the original branch in #436, so I duplicated the PR here so it can be merged |
JSCU-CNI
pushed a commit
to JSCU-CNI/dissect.target
that referenced
this pull request
Jan 2, 2024
This fixes ls and cat in target-shell when paths contain unicode characters.
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
This fixes ls and cat in target-shell when paths contain unicode characters.
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
This fixes ls and cat in target-shell when paths contain unicode characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds lexer.whitespace_split = True to shlex in target-shell which improves handling unicode arguments for argparse.
This fixes ls and cat in target-shell when paths contain unicode characters.