Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Symantec compatibility check #445

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix Symantec compatibility check #445

merged 1 commit into from
Nov 16, 2023

Conversation

cecinestpasunepipe
Copy link
Contributor

@cecinestpasunepipe cecinestpasunepipe commented Nov 14, 2023

Fix Symantec compatibility check.
Glob returns a generator which equals to True, even if empty. Also break doesn't work that way.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (a90e389) 74.35% compared to head (94fd324) 74.38%.
Report is 1 commits behind head on main.

Files Patch % Lines
dissect/target/plugins/os/unix/_os.py 0.00% 3 Missing ⚠️
dissect/target/plugins/os/unix/linux/esxi/_os.py 0.00% 2 Missing ⚠️
dissect/target/container.py 80.00% 1 Missing ⚠️
dissect/target/filesystem.py 92.30% 1 Missing ⚠️
dissect/target/plugins/apps/av/symantec.py 66.66% 1 Missing ⚠️
...ect/target/plugins/filesystem/ntfs/mft_timeline.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   74.35%   74.38%   +0.03%     
==========================================
  Files         258      258              
  Lines       20640    20661      +21     
==========================================
+ Hits        15346    15369      +23     
+ Misses       5294     5292       -2     
Flag Coverage Δ
unittests 74.38% <86.15%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe merged commit a4003f5 into main Nov 16, 2023
@cecinestpasunepipe cecinestpasunepipe deleted the fix/symantec branch November 16, 2023 16:01
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Fix Symantec compatibility check (#445)
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants