Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with targetd integration #446

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-2589)

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (c97c344) 73.91% compared to head (32e1fe2) 73.87%.

Files Patch % Lines
dissect/target/loaders/targetd.py 0.00% 9 Missing ⚠️
dissect/target/plugin.py 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   73.91%   73.87%   -0.05%     
==========================================
  Files         259      259              
  Lines       20874    20892      +18     
==========================================
+ Hits        15430    15433       +3     
- Misses       5444     5459      +15     
Flag Coverage Δ
unittests 73.87% <22.72%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2589_Targetd_Service_CTypes branch from 8ef854a to 32e1fe2 Compare November 23, 2023 10:43
@cecinestpasunepipe cecinestpasunepipe merged commit c6cfbbc into main Nov 23, 2023
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-2589_Targetd_Service_CTypes branch November 23, 2023 16:10
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants