Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _target to LnkRecord #449

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Add _target to LnkRecord #449

merged 2 commits into from
Nov 20, 2023

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented Nov 17, 2023

DIS-2510

@Poeloe Poeloe requested review from Horofic and pyrco November 17, 2023 14:14
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 168 lines in your changes are missing coverage. Please review.

Comparison is base (a4003f5) 74.38% compared to head (aef0f6e) 73.90%.
Report is 1 commits behind head on main.

Files Patch % Lines
dissect/target/filesystems/btrfs.py 2.60% 112 Missing ⚠️
dissect/target/filesystem.py 53.06% 23 Missing ⚠️
dissect/target/plugins/os/unix/_os.py 16.66% 20 Missing ⚠️
dissect/target/helpers/utils.py 36.36% 7 Missing ⚠️
dissect/target/target.py 78.57% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   74.38%   73.90%   -0.49%     
==========================================
  Files         258      259       +1     
  Lines       20661    20838     +177     
==========================================
+ Hits        15369    15400      +31     
- Misses       5292     5438     +146     
Flag Coverage Δ
unittests 73.90% <26.63%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Poeloe Poeloe merged commit 9162507 into main Nov 20, 2023
@Poeloe Poeloe deleted the fix/add-target-to-lnk-record branch November 20, 2023 15:19
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Poeloe added a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants