Make iexplore.downloads plugin more fail-safe #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
- Coverage 73.90% 73.89% -0.01%
==========================================
Files 259 259
Lines 20838 20846 +8
==========================================
+ Hits 15400 15405 +5
- Misses 5438 5441 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
requested changes
Nov 18, 2023
Co-authored-by: Erik Schamper <[email protected]>
Schamper
requested changes
Nov 20, 2023
|
|
||
| try: | ||
| response_headers = container_record.ResponseHeaders.decode("utf-16-le", errors="ignore") | ||
| ref_url, mime_type, temp_download_path, down_url, down_path = response_headers.split("\x00")[-6:-1] |
There was a problem hiding this comment.
To prevent future bugs, could you either initialize ref_url, mime_type and temp_download_path to None? Or replace those with _ and leave a comment explaining what those fields would be.
There was a problem hiding this comment.
Good one, changed it! Complemented the existing test as well, to prevent regression with the path/url value
Schamper
approved these changes
Nov 20, 2023
JSCU-CNI
pushed a commit
to JSCU-CNI/dissect.target
that referenced
this pull request
Jan 2, 2024
Poeloe
added a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.