Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct open method in several loaders #452

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Use correct open method in several loaders #452

merged 2 commits into from
Nov 21, 2023

Conversation

Schamper
Copy link
Member

This allows these loaders to function within other targets.

@Schamper Schamper changed the title Use current open method in several loaders Use correct open method in several loaders Nov 21, 2023
@Horofic Horofic self-assigned this Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e6ab5a1) 73.90% compared to head (bf1864a) 73.90%.

Files Patch % Lines
dissect/target/loaders/ad1.py 0.00% 1 Missing ⚠️
dissect/target/loaders/vma.py 0.00% 1 Missing ⚠️
dissect/target/loaders/xva.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   73.90%   73.90%           
=======================================
  Files         259      259           
  Lines       20863    20863           
=======================================
  Hits        15419    15419           
  Misses       5444     5444           
Flag Coverage Δ
unittests 73.90% <25.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper requested a review from Horofic November 21, 2023 12:16
@Schamper Schamper merged commit fa8af9b into main Nov 21, 2023
@Schamper Schamper deleted the fix-loader-open branch November 21, 2023 12:41
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants