-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial cookies implementation for Firefox and Chromium #453
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 73.80% 73.78% -0.03%
==========================================
Files 276 276
Lines 23005 23040 +35
==========================================
+ Hits 16978 16999 +21
- Misses 6027 6041 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@YoeriNijs thank you for your contribution! As this is your first code contribution, please read the following Contributor License Agreement (CLA). If you agree with the CLA, please reply with the following information:
Contributor License Agreement
Contribution License AgreementThis Contribution License Agreement ("Agreement") governs your Contribution(s) (as defined below) and conveys certain license rights to Fox-IT B.V. ("Fox-IT") for your Contribution(s) to Fox-IT"s open source Dissect project. This Agreement covers any and all Contributions that you ("You" or "Your"), now or in the future, Submit (as defined below) to this project. This Agreement is between Fox-IT B.V. and You and takes effect when you click an “I Accept” button, check box presented with these terms, otherwise accept these terms or, if earlier, when You Submit a Contribution.
|
@DissectBot agree |
Thank you for your contribution. I will be doing the review in the coming days. So stay tuned! |
@Horofic Thanks! I also refactored some tests today in order to obey the boyscout rule. I think we can increase the test quality by checking the record values as well, but this is future work ;) |
# Conflicts: # tests/plugins/apps/browser/test_browser.py
….target into cookies-implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also pushed some small style changes, and fixed the tests!
Co-authored-by: Schamper <[email protected]>
Co-authored-by: Schamper <[email protected]>
Initial cookies support for Firefox and Chromium. Missing iexplore since I do not run Windows atm. Unit tests may follow when I have some time remaining.