Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hash functionality #457

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Improve hash functionality #457

merged 5 commits into from
Nov 28, 2023

Conversation

Miauwkeru
Copy link
Contributor

(DIS-2623)

@Miauwkeru Miauwkeru requested a review from pyrco November 24, 2023 14:04
@Miauwkeru
Copy link
Contributor Author

@JSCU-CNI a heads-up there will be a change in what the record format will look like. To make it clearer which field belongs to what digest

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f062173) 73.87% compared to head (c440e73) 73.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   73.87%   73.88%   +0.01%     
==========================================
  Files         259      259              
  Lines       20893    20901       +8     
==========================================
+ Hits        15434    15442       +8     
  Misses       5459     5459              
Flag Coverage Δ
unittests 73.88% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miauwkeru Miauwkeru requested a review from pyrco November 27, 2023 08:49
@JSCU-CNI
Copy link
Contributor

Thanks for the heads-up @Miauwkeru.

@Miauwkeru Miauwkeru force-pushed the improve-hash-functionality branch from 54ec149 to 32cba04 Compare November 27, 2023 12:08
@Miauwkeru Miauwkeru requested a review from pyrco November 27, 2023 12:48
@Miauwkeru Miauwkeru merged commit 124896e into main Nov 28, 2023
@Miauwkeru Miauwkeru deleted the improve-hash-functionality branch November 28, 2023 08:42
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Add `<field_name>_resolved` and `<field_name>_digest` to the record for every resolvable path
inside that record.

(DIS-2623)
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Add `<field_name>_resolved` and `<field_name>_digest` to the record for every resolvable path
inside that record.

(DIS-2623)
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Add `<field_name>_resolved` and `<field_name>_digest` to the record for every resolvable path
inside that record.

(DIS-2623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants