Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the internal walkfs_ext plugin with Target.fs.walk_ext #459

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Nov 27, 2023

DIS-2251

@pyrco pyrco requested a review from Miauwkeru November 27, 2023 12:16
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (6f775ad) 73.88% compared to head (6d366e0) 73.96%.

Files Patch % Lines
...ssect/target/plugins/filesystem/unix/capability.py 84.90% 8 Missing ⚠️
dissect/target/plugins/filesystem/yara.py 69.23% 4 Missing ⚠️
dissect/target/plugins/filesystem/walkfs.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   73.88%   73.96%   +0.08%     
==========================================
  Files         259      259              
  Lines       20901    20917      +16     
==========================================
+ Hits        15442    15472      +30     
+ Misses       5459     5445      -14     
Flag Coverage Δ
unittests 73.96% <84.52%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco force-pushed the feature/dis-2251_replace-walkfs_ext branch from 43b4280 to 123426e Compare November 28, 2023 15:24
@pyrco pyrco requested a review from Miauwkeru November 28, 2023 15:24
@pyrco pyrco force-pushed the feature/dis-2251_replace-walkfs_ext branch from 123426e to 6d366e0 Compare November 30, 2023 07:50
@pyrco pyrco merged commit 11f7ba4 into main Nov 30, 2023
@pyrco pyrco deleted the feature/dis-2251_replace-walkfs_ext branch November 30, 2023 09:01
@pyrco pyrco mentioned this pull request Dec 15, 2023
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants