Fix permission issues when tests are run on windows #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
=======================================
Coverage 73.88% 73.88%
=======================================
Files 259 259
Lines 20901 20901
=======================================
Hits 15442 15442
Misses 5459 5459
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Miauwkeru
requested changes
Nov 28, 2023
On Windows, files can not be opened when already open. This gives issues when using temporary files. By not deleting a temporaryfile after it is closed and closing it after it is created, this is circumvented. By moving all these files into pytest's tmp_path, the tmp_path mechanism will take care of removing these temporary files.
pyrco
force-pushed
the
feature/dis-2010_fix-permission-issues-in-tests-on-windows
branch
from
7f21bd8 to
1b42460
Compare
Miauwkeru
reviewed
Nov 29, 2023
Miauwkeru
approved these changes
Nov 29, 2023
pyrco
deleted the
feature/dis-2010_fix-permission-issues-in-tests-on-windows
branch
JSCU-CNI
pushed a commit
to JSCU-CNI/dissect.target
that referenced
this pull request
Jan 2, 2024
On Windows, files can not be opened when already open. This gives issues when using temporary files. By not deleting a temporaryfile after it is closed and closing it after it is created, this is circumvented. By moving all these files into pytest's tmp_path, the tmp_path mechanism will take care of removing these temporary files.
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
On Windows, files can not be opened when already open. This gives issues when using temporary files. By not deleting a temporaryfile after it is closed and closing it after it is created, this is circumvented. By moving all these files into pytest's tmp_path, the tmp_path mechanism will take care of removing these temporary files.
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
On Windows, files can not be opened when already open. This gives issues when using temporary files. By not deleting a temporaryfile after it is closed and closing it after it is created, this is circumvented. By moving all these files into pytest's tmp_path, the tmp_path mechanism will take care of removing these temporary files.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, files can not be opened when already open. This gives issues when using temporary files. By not deleting a temporaryfile after it is closed and closing it after it is created, this is circumvented.
By moving all these files into pytest's tmp_path, the tmp_path mechanism will take care of removing these temporary files.