-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NamespacePlugin function filtering #463
Fix NamespacePlugin function filtering #463
Conversation
The previous check for subplugin export functions was too strict. It did not account for subplugins reusing export methods of others. Also improved handling unsupported plugins. Lastly, added a check for when a subplugin has an export function with the same name as the NameSpacePlugin to which it belongs. Added tests for the scenarios outlined above.
@MaxGroot thank you for your contribution! As this is your first code contribution, please read the following Contributor License Agreement (CLA). If you agree with the CLA, please reply with the following information:
Contributor License Agreement
Contribution License AgreementThis Contribution License Agreement ("Agreement") governs your Contribution(s) (as defined below) and conveys certain license rights to Fox-IT B.V. ("Fox-IT") for your Contribution(s) to Fox-IT"s open source Dissect project. This Agreement covers any and all Contributions that you ("You" or "Your"), now or in the future, Submit (as defined below) to this project. This Agreement is between Fox-IT B.V. and You and takes effect when you click an “I Accept” button, check box presented with these terms, otherwise accept these terms or, if earlier, when You Submit a Contribution.
|
@DissectBot agree |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
- Coverage 73.89% 73.88% -0.01%
==========================================
Files 271 271
Lines 22471 22476 +5
==========================================
+ Hits 16605 16607 +2
- Misses 5866 5869 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: cecinestpasunepipe <[email protected]> Co-authored-by: Erik Schamper <[email protected]>
While working on #384, I ran into some issues with the
NamespacePlugin
.UnsupportedPlugin
exceptions, in favour of handling anyException
with acontinue
.NamespacePlugin
subclass to which it belongs.