Fixed support for unprivileged accounts for the SMB loader & minor bug fix

[Paradoxis]

Fixed two bugs:

• Using target-shell with the SMB loader would crash when using unprivileged accounts (resolves SMB loader crashes on startup when using unprivileged accounts #465)
• The Windows OS plugin would crash target-shell if the detect() function failed to detect an OS (i.e.: when an unprivileged user only only able to list non OS-level shares).

[Paradoxis]

Important to note is that the registry still logs a verbose error, but it seems like intended behavior since it's logged explicitly.

2023-12-01T12:44:43.991136Z [warning  ] <Target .>: Failed to map drive letters [dissect.target.target] 
Traceback (most recent call last):
  File "dissect/target/plugins/os/windows/_os.py", line 52, in add_mounts
    for key in self.target.registry.keys("HKLM\\System\\MountedDevices"):
  File "dissect/target/plugins/os/windows/registry.py", line 296, in keys
    for key in self._iter_controlset_keypaths(keys):
  File "dissect/target/plugins/os/windows/registry.py", line 309, in _iter_controlset_keypaths
    if not self.controlsets or not CONTROLSET_REGEX.search(key):
           ^^^^^^^^^^^^^^^^
  File "dissect/target/plugins/os/windows/registry.py", line 206, in controlsets
    for key in self.key("HKLM\\SYSTEM").subkeys():
               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "dissect/target/plugins/os/windows/registry.py", line 265, in key
    res = self._root.key(key)
          ^^^^^^^^^^^^^^^^^^^
  File "dissect/target/helpers/regutil.py", line 282, in key
    vkey = vkey.subkey(part)
           ^^^^^^^^^^^^^^^^^
  File "dissect/target/helpers/regutil.py", line 345, in subkey
    raise RegistryKeyNotFoundError(subkey)
dissect.target.exceptions.RegistryKeyNotFoundError: HKEY_LOCAL_MACHINE
Unknown-windows />

[Schamper]

Important to note is that the registry still logs a verbose error, but it seems like intended behavior since it's logged explicitly.

That should probably be separated out into a log.warning for the message and a log.debug for the stacktrace.

[Paradoxis]

@Schamper applied changes, although the stack trace originates from the windows plugin meaning it will still be printed as far as I know

[Schamper]

@Schamper applied changes, although the stack trace originates from the windows plugin meaning it will still be printed as far as I know

You could change these lines: https://github.com/fox-it/dissect.target/blob/main/dissect/target/plugins/os/windows/_os.py#L80

self.target.log.warning("Failed to map drive letters")
self.target.log.debug("", exc_info=e)

[Paradoxis]

@Schamper applied changes, although the stack trace originates from the windows plugin meaning it will still be printed as far as I know

You could change these lines: https://github.com/fox-it/dissect.target/blob/main/dissect/target/plugins/os/windows/_os.py#L80

self.target.log.warning("Failed to map drive letters")
self.target.log.debug("", exc_info=e)

Added :)

[Schamper]

Can you fix the CI errors?

[Paradoxis]

Can you fix the CI errors?

@Schamper Fixed linting issues & added missing mock import

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8674c31) 73.94% compared to head (c85ccf5) 73.93%.

Files	Patch %	Lines
dissect/target/loaders/smb.py	76.19%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
- Coverage   73.94%   73.93%   -0.02%     
==========================================
  Files         259      259              
  Lines       20878    20888      +10     
==========================================
+ Hits        15439    15444       +5     
- Misses       5439     5444       +5     

Flag	Coverage Δ
unittests	73.93% <80.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.