Fix most tests for windows computers #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Miauwkeru
commented
Dec 1, 2023
Miauwkeru
commented
- Check whether effective_ids is enabled for the system
- Use type consistently
- Open files as UTF-8 by default
- Fix paths in test_target.py
- Change all occurrences to flow.record path to self.target.fs.path
- Fix issues regarding the resolver in trusteddocs
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
+ Coverage 73.88% 73.94% +0.06%
==========================================
Files 259 259
Lines 20901 20878 -23
==========================================
- Hits 15442 15439 -3
+ Misses 5459 5439 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
previously requested changes
Dec 3, 2023
There was a problem hiding this comment.
Accidentally added or intentional addition? Missing a __init__.py if the latter case.
There was a problem hiding this comment.
Oh, it was an accident on my part that I added the nixos/_os.py in this pr... I will take it with me to a future iteration
| @@ -73,7 +73,7 @@ def trusteddocs(self) -> Iterator[TrustedDocumentsRecord]: | |||
| ts=key.ts, | |||
| type=value.type, | |||
| application=application, | |||
| document_path=self.target.resolve(value.name), | |||
| document_path=self.target.fs.path(self.target.resolve(value.name)), | |||
There was a problem hiding this comment.
Perhaps .resolve() should return a path?
There was a problem hiding this comment.
That might be a good idea for the future yes.
Miauwkeru
force-pushed
the
fix-windows-tests
branch
from
1d1c567 to
589ff69
Compare
Poeloe
requested changes
Dec 5, 2023
Miauwkeru
force-pushed
the
fix-windows-tests
branch
from
6d5e97c to
ea0f030
Compare
Miauwkeru
dismissed
Schamper’s stale review
Made the ticket and resolved the review comments
JSCU-CNI
pushed a commit
to JSCU-CNI/dissect.target
that referenced
this pull request
Jan 2, 2024
* Check whether effective_ids is enabled for the system * Use __type__ consistently * Open files as UTF-8 by default * Fix paths in test_target.py * Change all occurrences to flow.record path to self.target.fs.path * Fix issues regarding the resolver in trusteddocs
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Check whether effective_ids is enabled for the system * Use __type__ consistently * Open files as UTF-8 by default * Fix paths in test_target.py * Change all occurrences to flow.record path to self.target.fs.path * Fix issues regarding the resolver in trusteddocs
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
* Check whether effective_ids is enabled for the system * Use __type__ consistently * Open files as UTF-8 by default * Fix paths in test_target.py * Change all occurrences to flow.record path to self.target.fs.path * Fix issues regarding the resolver in trusteddocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.