Fix unix activity plugin #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
reviewed
Dec 6, 2023
Schamper
approved these changes
Dec 7, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 74.01% 74.00% -0.01%
==========================================
Files 259 259
Lines 20952 20955 +3
==========================================
+ Hits 15507 15508 +1
- Misses 5445 5447 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
When a target system contains (broken) symlinks in /var/log, the activity plugin could break.
pyrco
force-pushed
the
fix/unix-activity-plugin
branch
from
ffb3e36 to
7555ce4
Compare
JSCU-CNI
added a commit
to JSCU-CNI/dissect.target
that referenced
this pull request
Jan 2, 2024
When a target system contains (broken) symlinks in /var/log, the activity plugin could break.
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
When a target system contains (broken) symlinks in /var/log, the activity plugin could break.
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
When a target system contains (broken) symlinks in /var/log, the activity plugin could break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a target system contains (broken) symlinks in `/var/log, the activity plugin could break. This is now fixed by checking if a file is a symlink or if it exists at all.