Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sru plugin #472

Merged
merged 11 commits into from
Jan 3, 2024
Merged

Improve sru plugin #472

merged 11 commits into from
Jan 3, 2024

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Dec 6, 2023

Previously all sru plugin functions would throw an uncaught exception when the windows target does not contain a certain sru table. The plugin now gracefully exits with a warning when an sru table does not exist.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've also been meaning to change this plugin to use the information from the registry to dump available tables. But that's something for a different PR.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the unit tests?

@Schamper
Copy link
Member

Schamper commented Jan 2, 2024

Looks like a different unit test doesn't like the year rollover 🙃 unfortunately we'll need to fix that first. The yum plugin uses the modification timestamp for the year rollover, but the CI probably changes the modification timestamp upon checkout.

(#492 to fix that)

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44c6613) 74.08% compared to head (27e16bf) 74.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   74.08%   74.07%   -0.01%     
==========================================
  Files         261      261              
  Lines       21110    21113       +3     
==========================================
+ Hits        15639    15640       +1     
- Misses       5471     5473       +2     
Flag Coverage Δ
unittests 74.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Erik Schamper <[email protected]>
@Schamper Schamper merged commit c901188 into fox-it:main Jan 3, 2024
@JSCU-CNI JSCU-CNI deleted the fix/windows-sru-table branch February 15, 2024 12:39
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants