-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve sru plugin #472
Improve sru plugin #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've also been meaning to change this plugin to use the information from the registry to dump available tables. But that's something for a different PR.
Co-authored-by: Erik Schamper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the unit tests?
Co-authored-by: Erik Schamper <[email protected]>
Looks like a different unit test doesn't like the year rollover 🙃 unfortunately we'll need to fix that first. The yum plugin uses the modification timestamp for the year rollover, but the CI probably changes the modification timestamp upon checkout. (#492 to fix that) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
- Coverage 74.08% 74.07% -0.01%
==========================================
Files 261 261
Lines 21110 21113 +3
==========================================
+ Hits 15639 15640 +1
- Misses 5471 5473 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Erik Schamper <[email protected]>
Previously all sru plugin functions would throw an uncaught exception when the windows target does not contain a certain sru table. The plugin now gracefully exits with a warning when an sru table does not exist.