Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the retrieval of plugins #476

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Dec 8, 2023

No description provided.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (688dcb9) 73.94% compared to head (f67024e) 73.95%.

Files Patch % Lines
dissect/target/plugin.py 91.07% 5 Missing ⚠️
dissect/target/tools/query.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   73.94%   73.95%           
=======================================
  Files         260      260           
  Lines       21032    21017   -15     
=======================================
- Hits        15553    15543   -10     
+ Misses       5479     5474    -5     
Flag Coverage Δ
unittests 73.95% <89.06%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been meaning to also change some of the way plugins are stored in the tree. Right now it's sub-optimal for the default and preferred method of retrieving plugins (by function name).

I was thinking of making the tree function-first, so e.g.:

{
    "services": [{<windows services plugin definition>}, {unix services plugin definition}]
}

This would optimize for the happy path of plugin retrieval.

Since you're touching a lot of the plugin system here, could this fit in this PR or make it easier to change the tree to that format in the future?

@pyrco
Copy link
Contributor Author

pyrco commented Dec 11, 2023

I think that is a bit too different scope for this change. It also needs a bit more thinking and designing. So for another time.

@pyrco pyrco requested a review from Schamper December 11, 2023 08:46
@pyrco pyrco linked an issue Dec 12, 2023 that may be closed by this pull request
@pyrco pyrco force-pushed the feature/dis-2792_fix-plugin-retrieval branch from ab129bb to 2584157 Compare December 19, 2023 10:39
@pyrco pyrco force-pushed the feature/dis-2792_fix-plugin-retrieval branch from 2584157 to adeafa5 Compare December 20, 2023 15:02
@pyrco pyrco force-pushed the feature/dis-2792_fix-plugin-retrieval branch from adeafa5 to f67024e Compare December 20, 2023 15:18
@pyrco pyrco merged commit ced76c8 into main Dec 20, 2023
@pyrco pyrco deleted the feature/dis-2792_fix-plugin-retrieval branch December 20, 2023 16:02
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PluginListPlugin output is nondeterministic
3 participants