-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the retrieval of plugins #476
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
=======================================
Coverage 73.94% 73.95%
=======================================
Files 260 260
Lines 21032 21017 -15
=======================================
- Hits 15553 15543 -10
+ Misses 5479 5474 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been meaning to also change some of the way plugins are stored in the tree. Right now it's sub-optimal for the default and preferred method of retrieving plugins (by function name).
I was thinking of making the tree function-first, so e.g.:
{
"services": [{<windows services plugin definition>}, {unix services plugin definition}]
}
This would optimize for the happy path of plugin retrieval.
Since you're touching a lot of the plugin system here, could this fit in this PR or make it easier to change the tree to that format in the future?
I think that is a bit too different scope for this change. It also needs a bit more thinking and designing. So for another time. |
ab129bb
to
2584157
Compare
2584157
to
adeafa5
Compare
adeafa5
to
f67024e
Compare
No description provided.