Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit loader Option #480

Merged
merged 24 commits into from
Dec 22, 2023
Merged

Explicit loader Option #480

merged 24 commits into from
Dec 22, 2023

Conversation

cecinestpasunepipe
Copy link
Contributor

@cecinestpasunepipe cecinestpasunepipe commented Dec 11, 2023

(DIS-2029/DIS-2028)

@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2029 branch 2 times, most recently from 20179a5 to 3948446 Compare December 11, 2023 16:06
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cbc5bd2) 73.96% compared to head (ba82fcf) 73.99%.

Files Patch % Lines
dissect/target/tools/query.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   73.96%   73.99%   +0.03%     
==========================================
  Files         260      260              
  Lines       21038    21064      +26     
==========================================
+ Hits        15561    15587      +26     
  Misses       5477     5477              
Flag Coverage Δ
unittests 73.99% <97.36%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe
Copy link
Contributor Author

Important note: this PR now also covers DIS-2028.

@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2029 branch 2 times, most recently from ff6e0d5 to dab52a0 Compare December 15, 2023 09:18
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only noticed just now that the original variable was called vfs, apologies. I see no need to change that.

cecinestpasunepipe and others added 22 commits December 22, 2023 14:14
@cecinestpasunepipe cecinestpasunepipe merged commit 2e59983 into main Dec 22, 2023
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-2029 branch December 22, 2023 13:41
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants