Add support for birth timestamps in extfs / walkfs #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrco
requested changes
Dec 12, 2023
Schamper
reviewed
Dec 12, 2023
The walkfs plugin would always report btime=None, which is a shame since ext4 does support birth timestamps (called crtime in ext lingo). dissect.extfs already supported crtime, so a simple fix suffices.
syzzer
force-pushed
the
walkfs_crtime
branch
from
aa75c35 to
531947b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
- Coverage 74.02% 74.02% -0.01%
==========================================
Files 259 259
Lines 20945 20948 +3
==========================================
+ Hits 15505 15506 +1
- Misses 5440 5442 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pyrco
approved these changes
Dec 13, 2023
JSCU-CNI
pushed a commit
to JSCU-CNI/dissect.target
that referenced
this pull request
Jan 2, 2024
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The walkfs plugin would always report btime=None, which is a shame since ext4 does support birth timestamps (called crtime in ext lingo).
dissect.extfs already supported crtime, so a simple fix suffices.