Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default docstrings to OSPlugin subclass methods #483

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Dec 12, 2023

No description provided.

@pyrco pyrco requested a review from Schamper December 12, 2023 16:03
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d041cab) 73.94% compared to head (3caa0c7) 73.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
+ Coverage   73.94%   73.96%   +0.01%     
==========================================
  Files         260      260              
  Lines       21020    21034      +14     
==========================================
+ Hits        15544    15558      +14     
  Misses       5476     5476              
Flag Coverage Δ
unittests 73.96% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco linked an issue Dec 12, 2023 that may be closed by this pull request
@pyrco pyrco force-pushed the feature/dis-2792_fix-plugin-retrieval branch 3 times, most recently from adeafa5 to f67024e Compare December 20, 2023 15:18
@pyrco pyrco force-pushed the feature/dis-845_add-docstrings-to-osplugins branch from 3ff090c to 9b88e87 Compare December 20, 2023 15:20
Base automatically changed from feature/dis-2792_fix-plugin-retrieval to main December 20, 2023 16:02
@pyrco pyrco force-pushed the feature/dis-845_add-docstrings-to-osplugins branch from 9b88e87 to 0b8f418 Compare December 20, 2023 16:04
@pyrco pyrco force-pushed the feature/dis-845_add-docstrings-to-osplugins branch 2 times, most recently from 4be7a82 to 9df8e58 Compare December 20, 2023 18:01
@pyrco pyrco requested a review from Schamper December 20, 2023 18:01
@pyrco pyrco force-pushed the feature/dis-845_add-docstrings-to-osplugins branch from 9df8e58 to 3caa0c7 Compare December 21, 2023 08:09
@pyrco pyrco requested a review from Schamper December 21, 2023 08:09
@pyrco pyrco merged commit 82eb186 into main Dec 21, 2023
@pyrco pyrco deleted the feature/dis-845_add-docstrings-to-osplugins branch December 21, 2023 10:02
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PluginListPlugin output is nondeterministic
2 participants