Add --resolve to target-query #485
Conversation
dissect/target/filesystem.py
Outdated
| return hashutil.custom(fd, algos) | ||
| return hashutil.common(fd) |
There was a problem hiding this comment.
from a debug artifact that I didn't revert correctly
dissect/target/filesystem.py
Outdated
There was a problem hiding this comment.
I can't comment on it, but could you maybe also replace all instances of List in this file with list?
| @@ -67,7 +67,7 @@ def firewall(self): | |||
| data[fname] = value | |||
|
|
|||
| if "app" in data: | |||
| data["app"] = self.target.resolve(data["app"]) | |||
| data["app"] = str(self.target.resolve(data["app"])) | |||
There was a problem hiding this comment.
Shouldn't the app field in the record become a path?
There was a problem hiding this comment.
techically it should, i did see some instances it wasn't a path tho. but some other information
There was a problem hiding this comment.
seems I was mistaken on that front, that was another changed app
dissect/target/tools/query.py
Outdated
| modifier = None | ||
|
|
||
| if args.resolve: | ||
| modifier = modifier.Modifier.RESOLVE |
There was a problem hiding this comment.
Doesn't this conflict with the import name?
There was a problem hiding this comment.
That it did, that was an oversight
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
+ Coverage 74.05% 74.07% +0.02%
==========================================
Files 260 261 +1
Lines 21070 21110 +40
==========================================
+ Hits 15603 15638 +35
- Misses 5467 5472 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: pyrco <[email protected]>
Miauwkeru
force-pushed
the
DIS-2624-create-resolve-command
branch
from
55e3592 to
c28c323
Compare
* Changes the target.resolve() functionality to return a TargetPath * Create modifiers that can change records before printing them. (DIS-2624)
* Changes the target.resolve() functionality to return a TargetPath * Create modifiers that can change records before printing them. (DIS-2624)
Moves all the record modifier code to helpers/modifier.py
Adds modifier logic, to allow for more modifiers to get added later (currently only paths get used)
open the target_path during hashing:
When opened in a DirLoader, the OS will "open" the file
However, the file never got closed, so on linux you'd get
an error that the maximum open files threshold was reached