Fix finding namespace plugins that do not want to be __findable__ #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
- Coverage 73.95% 73.94% -0.01%
==========================================
Files 260 260
Lines 21017 21020 +3
==========================================
+ Hits 15543 15544 +1
- Misses 5474 5476 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cecinestpasunepipe
suggested changes
Dec 20, 2023
dissect/target/plugin.py
Outdated
| # (if there is a subtree). | ||
| # | ||
| # Examples: | ||
| # -f browser -> apps.browser.browsers* (the whole package, due to a namespace match) |
There was a problem hiding this comment.
-f browser doesn't work?
target-query: error: argument -f/--function contains invalid plugin(s): browser
There was a problem hiding this comment.
Works here? It didn't work before this patch, as this is the thing it tries to fix.
pyrco
force-pushed
the
feature/dis-2901_fix-finding-non-finadable-namespace-plugins
branch
from
3c5b3ce to
6ce83b3
Compare
Base automatically changed from
feature/dis-2792_fix-plugin-retrieval
to
main
December 20, 2023 16:02
pyrco
force-pushed
the
feature/dis-2901_fix-finding-non-finadable-namespace-plugins
branch
from
6ce83b3 to
35c8db3
Compare
pyrco
force-pushed
the
feature/dis-2901_fix-finding-non-finadable-namespace-plugins
branch
from
35c8db3 to
71dff7a
Compare
Schamper
changed the title
cecinestpasunepipe
approved these changes
Dec 20, 2023
pyrco
deleted the
feature/dis-2901_fix-finding-non-finadable-namespace-plugins
branch
JSCU-CNI
pushed a commit
to JSCU-CNI/dissect.target
that referenced
this pull request
Jan 2, 2024
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-2901)