Fix the glob_ext() filesystem globbing function #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
=======================================
Coverage 74.07% 74.08%
=======================================
Files 261 261
Lines 21110 21110
=======================================
+ Hits 15638 15639 +1
+ Misses 5472 5471 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
requested changes
Jan 2, 2024
pyrco
force-pushed
the
feature/dis-2903_filesystem-globbing-fixes
branch
from
f8b9b92 to
aba7798
Compare
|
No regression unit test? 😄 |
pyrco
force-pushed
the
feature/dis-2903_filesystem-globbing-fixes
branch
from
aba7798 to
7c6f5d3
Compare
|
I added some tests 😉 |
Schamper
approved these changes
Jan 3, 2024
When passed a pattern with path parts which did not contain any globs, the function would fail due to path strings instead of FilesystemEntry's being used. Documentation and comments are added to the glob_ext*() functions and they are refactored a bit. (DIS-2903)
pyrco
force-pushed
the
feature/dis-2903_filesystem-globbing-fixes
branch
from
7c6f5d3 to
09b5256
Compare
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
When passed a pattern with path parts which did not contain any globs, the function would fail due to path strings instead of FilesystemEntry's being used. Documentation and comments are added to the glob_ext*() functions and they are refactored a bit. (DIS-2903)
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
When passed a pattern with path parts which did not contain any globs, the function would fail due to path strings instead of FilesystemEntry's being used. Documentation and comments are added to the glob_ext*() functions and they are refactored a bit. (DIS-2903)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passed a pattern with path parts which did not contain any globs, the function would fail due to path strings instead of FilesystemEntry's being used.
Documentation and comments are added to the glob_ext*() functions and they are refactored a bit.
(DIS-2903)