Fix Velociraptor Loader Windows root filesystem detection #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mount volumes that represent drives before the volume shadow copies, otherwise a volume shadow copy is used as root filesystem.
Zawadidone
changed the title
Schamper
requested changes
Dec 27, 2023
…issect.target into fix/velociraptor_loader_vss
This was always the case but not documented.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
==========================================
+ Coverage 73.99% 74.05% +0.05%
==========================================
Files 260 260
Lines 21066 21070 +4
==========================================
+ Hits 15588 15603 +15
+ Misses 5478 5467 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
approved these changes
Dec 28, 2023
Schamper
requested changes
Dec 28, 2023
Schamper
approved these changes
Dec 28, 2023
JSCU-CNI
pushed a commit
to JSCU-CNI/dissect.target
that referenced
this pull request
Jan 2, 2024
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
added a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mount volumes that represent drives before the volume shadow copies, otherwise a volume shadow copy is used as root filesystem.
dissect.target/dissect/target/plugins/os/windows/_os.py
Lines 24 to 26 in 8bb86ca