Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PuTTY plugin (copy) #491

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Jan 2, 2024

The local rebase was a bit of a mess so I've created a new PR.

See the previous PR for feedback history (#418).

see previous PR for feedback history: fox-it#418
@JSCU-CNI JSCU-CNI mentioned this pull request Jan 2, 2024
@Schamper Schamper requested a review from Horofic January 2, 2024 15:36
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c901188) 74.07% compared to head (e5c565f) 74.18%.

Files Patch % Lines
dissect/target/plugins/apps/ssh/putty.py 93.26% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   74.07%   74.18%   +0.10%     
==========================================
  Files         261      263       +2     
  Lines       21113    21222     +109     
==========================================
+ Hits        15640    15744     +104     
- Misses       5473     5478       +5     
Flag Coverage Δ
unittests 74.18% <94.35%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 011323d into fox-it:main Jan 5, 2024
@JSCU-CNI JSCU-CNI deleted the feature/add-putty-plugin-2 branch February 15, 2024 12:38
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants