Add support for XML configuration files #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecinestpasunepipe
force-pushed
the
DIS-2157_Config_parser_xml
branch
2 times, most recently
from
3637f6c to
fc1494c
Compare
cecinestpasunepipe
force-pushed
the
DIS-2157_Config_parser_xml
branch
from
fc1494c to
d4b682e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
==========================================
+ Coverage 73.46% 73.51% +0.04%
==========================================
Files 276 276
Lines 22953 22997 +44
==========================================
+ Hits 16863 16906 +43
- Misses 6090 6091 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
reviewed
Jan 5, 2024
Co-authored-by: Erik Schamper <[email protected]>
Miauwkeru
reviewed
Jan 8, 2024
Horofic
requested changes
Jan 11, 2024
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
cecinestpasunepipe
force-pushed
the
DIS-2157_Config_parser_xml
branch
4 times, most recently
from
51220b4 to
e513d18
Compare
Co-authored-by: Erik Schamper <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
…t.target into DIS-2157_Config_parser_xml
Horofic
requested changes
Jan 24, 2024
Horofic
reviewed
Jan 24, 2024
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
Horofic
approved these changes
Jan 26, 2024
Closed
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-2157)