Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log verbosity of wildcard keychain values #501

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

Schamper
Copy link
Member

Also strip quotes from recovery key and file values, in case those were added with a quote for e.g. spaces in them.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (ab6a81e) 73.91% compared to head (87e5472) 73.89%.

Files Patch % Lines
dissect/target/volumes/bde.py 0.00% 14 Missing ⚠️
dissect/target/volumes/luks.py 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   73.91%   73.89%   -0.02%     
==========================================
  Files         271      271              
  Lines       22460    22471      +11     
==========================================
+ Hits        16601    16605       +4     
- Misses       5859     5866       +7     
Flag Coverage Δ
unittests 73.89% <17.64%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic self-requested a review January 12, 2024 11:57
@Schamper Schamper merged commit 85ee955 into main Jan 12, 2024
@Schamper Schamper deleted the reduce-encrypted-volume-verbosity branch January 12, 2024 12:16
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants