-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial FortiOS support #503
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
- Coverage 73.89% 73.58% -0.31%
==========================================
Files 273 275 +2
Lines 22663 22806 +143
==========================================
+ Hits 16747 16782 +35
- Misses 5916 6024 +108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
77b8e59
to
6759b91
Compare
return super().users() | ||
|
||
|
||
def repair_lzma_stream(fh: BinaryIO) -> BinaryIO: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Now depends on fox-it/dissect.util#39 |
Co-authored-by: pyrco <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one testcase that fails
Likely because this PR now depends on fox-it/dissect.util#39. I moved the XZ repair code into dissect.util. |
Co-authored-by: JSCU-CNI <[email protected]>
Co-authored-by: JSCU-CNI <[email protected]>
This PR adds initial support for FortiOS images (currently tested with the VMs of FortiGate and FortiAnalyzer. The goal is to have some initial support available at first, and expand later on as more time for research becomes available.
For example, we also have some parsers for various log files, but they require some cleaning up as well as needing to figure out how feasible it is to parse those straight from a FortiOS image.