Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial FortiOS support #503

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Initial FortiOS support #503

merged 6 commits into from
Jan 22, 2024

Conversation

Schamper
Copy link
Member

This PR adds initial support for FortiOS images (currently tested with the VMs of FortiGate and FortiAnalyzer. The goal is to have some initial support available at first, and expand later on as more time for research becomes available.

For example, we also have some parsers for various log files, but they require some cleaning up as well as needing to figure out how feasible it is to parse those straight from a FortiOS image.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 196 lines in your changes are missing coverage. Please review.

Comparison is base (18d9634) 73.89% compared to head (9b55567) 73.58%.

Files Patch % Lines
...issect/target/plugins/os/unix/linux/fortios/_os.py 22.02% 177 Missing ⚠️
...ct/target/plugins/os/unix/linux/fortios/generic.py 60.00% 8 Missing ⚠️
...ect/target/plugins/os/unix/linux/fortios/locale.py 61.11% 7 Missing ⚠️
dissect/target/plugins/os/unix/_os.py 33.33% 2 Missing ⚠️
dissect/target/plugins/os/unix/generic.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   73.89%   73.58%   -0.31%     
==========================================
  Files         273      275       +2     
  Lines       22663    22806     +143     
==========================================
+ Hits        16747    16782      +35     
- Misses       5916     6024     +108     
Flag Coverage Δ
unittests 73.58% <30.98%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return super().users()


def repair_lzma_stream(fh: BinaryIO) -> BinaryIO:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@Schamper
Copy link
Member Author

Now depends on fox-it/dissect.util#39

@Schamper Schamper requested a review from pyrco January 19, 2024 13:08
Copy link
Contributor

@pyrco pyrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one testcase that fails

@Schamper
Copy link
Member Author

There is one testcase that fails

Likely because this PR now depends on fox-it/dissect.util#39. I moved the XZ repair code into dissect.util.

@Schamper Schamper merged commit b49ee9b into main Jan 22, 2024
@Schamper Schamper deleted the initial-fortios branch January 22, 2024 15:35
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants