Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging and error handling #504

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Improve logging and error handling #504

merged 3 commits into from
Jan 15, 2024

Conversation

Schamper
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (a88e7f0) 74.03% compared to head (c60d605) 72.69%.

Files Patch % Lines
dissect/target/tools/query.py 56.98% 40 Missing ⚠️
dissect/target/tools/info.py 4.76% 20 Missing ⚠️
dissect/target/tools/reg.py 0.00% 20 Missing ⚠️
dissect/target/tools/dd.py 0.00% 7 Missing ⚠️
dissect/target/tools/fs.py 14.28% 6 Missing ⚠️
dissect/target/tools/mount.py 42.85% 4 Missing ⚠️
dissect/target/tools/shell.py 40.00% 3 Missing ⚠️
dissect/target/target.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   74.03%   72.69%   -1.34%     
==========================================
  Files         272      272              
  Lines       22531    22572      +41     
==========================================
- Hits        16681    16409     -272     
- Misses       5850     6163     +313     
Flag Coverage Δ
unittests 72.69% <40.69%> (-1.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper requested a review from Horofic January 14, 2024 22:46
@Schamper Schamper requested a review from Horofic January 15, 2024 09:32
@Schamper Schamper merged commit aa23241 into main Jan 15, 2024
@Schamper Schamper deleted the improve-error-handling branch January 15, 2024 09:47
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants