Fix hostname plugin for RedHat systems #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 73.76% 73.79% +0.03%
==========================================
Files 276 276
Lines 22997 23012 +15
==========================================
+ Hits 16963 16981 +18
+ Misses 6034 6031 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cecinestpasunepipe
suggested changes
Jan 23, 2024
pyrco
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Could you change the commit/PR message according to https://docs.dissect.tools/en/latest/contributing/style-guide.html#commit-message-style-and-formatting
The functionality of the injected target is not RedHat specific, hence a target of type Unix is more fitting. Changed therefore the injected target for the tests to be Unix. (#DIS-2796)
…type path This commit removes a redundant conversion from str to Path. These can be better compared through getting a string representation from a Path, which is less expensive.
florisvanstal
changed the title
cecinestpasunepipe
suggested changes
Jan 26, 2024
These tests cover cases where the path supplied does not match the expected path or the file is empty. These test cases highlighted bugs introduced from past commits, which are also fixed in this commit.
cecinestpasunepipe
previously approved these changes
Jan 29, 2024
cecinestpasunepipe
approved these changes
Jan 29, 2024
Schamper
changed the title
pyrco
approved these changes
Jan 30, 2024
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote as fix for ticket DIS-2796, where the hostname could not be found for Red Hat systems. The hostname for these files is instead of /etc/hostname found within /etc/sysconfig/network.