Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iexplore download records to use a proper path #521

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fix iexplore download records to use a proper path #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dissect/target/plugins/apps/browser/iexplore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def downloads(self) -> Iterator[BrowserDownloadRecord]:
ts_end=ts_end,
browser="iexplore",
id=container_record.EntryId,
path=down_path,
path=self.target.fs.path(down_path),
url=down_url,
size=None,
state=None,
Expand Down
3 changes: 2 additions & 1 deletion tests/plugins/apps/browser/test_iexplore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from typing import Iterator

import pytest
from flow.record.fieldtypes import path

from dissect.target import Target
from dissect.target.filesystem import VirtualFilesystem
Expand Down Expand Up @@ -34,5 +35,5 @@ def test_iexplore_history(target_iexplore: Target) -> None:
def test_iexplore_downloads(target_iexplore: Target) -> None:
records = list(target_iexplore.iexplore.downloads())
assert len(records) == 1
assert records[0].path.as_posix() == "C:\\Users\\John\\Downloads\\archlinux-2023.02.01-x86_64.iso"
assert records[0].path == path.from_windows("C:\\Users\\John\\Downloads\\archlinux-2023.02.01-x86_64.iso")
assert records[0].url == "https://mirror.cj2.nl/archlinux/iso/2023.02.01/archlinux-2023.02.01-x86_64.iso"
Loading