Fix removing get_all_records() exports by plugin_function_index() #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
=======================================
Coverage 73.68% 73.69%
=======================================
Files 277 277
Lines 23052 23056 +4
=======================================
+ Hits 16987 16990 +3
- Misses 6065 6066 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Miauwkeru
approved these changes
Feb 6, 2024
The copy made of the global plugin list was to shallow, resulting in the get_all_records() exports being removed from the list of exports. DIS-2971
pyrco
force-pushed
the
feature/dis-2971_fix-removal-of-get-all-records-exports
branch
from
3afec31 to
d650ed3
Compare
pyrco
deleted the
feature/dis-2971_fix-removal-of-get-all-records-exports
branch
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
The copy made of the global plugin list was to shallow, resulting in the get_all_records() exports being removed from the list of exports. DIS-2971
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
…x-it#527) The copy made of the global plugin list was to shallow, resulting in the get_all_records() exports being removed from the list of exports. DIS-2971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy made of the global plugin list was to shallow, resulting in the get_all_records() exports being removed from the list of exports.
DIS-2971