Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small consistency fixes in browser plugins #529

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Small consistency fixes in browser plugins #529

merged 2 commits into from
Feb 8, 2024

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Feb 7, 2024

Mostly moving around of some functions, and adding a source field to the cookies record.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0960572) 73.69% compared to head (43eab18) 73.69%.

Files Patch % Lines
dissect/target/plugins/apps/browser/chromium.py 93.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         277      277           
  Lines       23056    23056           
=======================================
  Hits        16990    16990           
  Misses       6066     6066           
Flag Coverage Δ
unittests 73.69% <93.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper requested a review from Miauwkeru February 7, 2024 12:12
@Schamper Schamper merged commit 0f4631d into main Feb 8, 2024
16 checks passed
@Schamper Schamper deleted the browser-fixes branch February 8, 2024 13:36
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants